jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types
with mypy.
URL: https://github.com/apache/airflow/pull/4685#discussion_r255773545
##########
File path: airflow/contrib/operators/adls_list_operator.py
##########
@@ -46,7 +48,7 @@ class AzureDataLakeStorageListOperator(BaseOperator):
azure_data_lake_conn_id='azure_data_lake_default'
)
"""
- template_fields = ('path',)
+ template_fields = ('path',) # type: Sequence[str]
Review comment:
Seems like we need to set types explicitly for classes that we subclass
elsewhere. Defining `template_fields` here gives it a type of `Tuple[str]`,
which is incompatible with the type `Tuple[str, str]` in the subclass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
