jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types
with mypy.
URL: https://github.com/apache/airflow/pull/4685#discussion_r256252901
##########
File path: setup.py
##########
@@ -319,6 +318,7 @@ def do_setup():
'sqlalchemy>=1.1.15, <1.3.0',
'tabulate>=0.7.5, <=0.8.2',
'tenacity==4.12.0',
+ 'typing',
Review comment:
Thanks, updated to install conditional on python version.
I don't see why we couldn't check a flag before importing, but what's the
benefit? The `typing` module is trivially fast to import, it's in the standard
library for versions of python that aren't soon to be EOL, and for older
versions, the wheel is ~25kb.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
