jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types
with mypy.
URL: https://github.com/apache/airflow/pull/4685#discussion_r257444670
##########
File path: setup.py
##########
@@ -319,6 +318,7 @@ def do_setup():
'sqlalchemy>=1.1.15, <1.3.0',
'tabulate>=0.7.5, <=0.8.2',
'tenacity==4.12.0',
+ 'typing',
Review comment:
Thanks @techalchemy. This patch installs `typing` conditional on python
version like you described. Conditionally importing expensive modules for type
checking makes sense, but as far as I can tell, the only imports I'm doing for
type checking here are from the `typing` module: `Sequence`, `Optional`, etc.
Those aren't expensive to import, and we have to import `typing` anyway to
figure out if we're type checking, like you pointed out--so I'm not sure we
need conditional imports yet. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
