zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257074811
########## File path: tests/contrib/sensors/test_redis_pub_sub_sensor.py ########## @@ -0,0 +1,90 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +import unittest +import logging +from airflow import DAG +from airflow import configuration +from airflow.contrib.sensors.redis_pub_sub_sensor import RedisPubSubSensor +from airflow.utils import timezone +from mock import patch +from mock import call + +from unittest.mock import MagicMock Review comment: @mans2singh FYI, CI failed due to `from unittest.mock import MagicMock`. Maybe you could do ```suggestion from mock import MagicMock ``` and than optimize imports ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
