zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257462867
########## File path: airflow/contrib/sensors/redis_pub_sub_sensor.py ########## @@ -0,0 +1,72 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from airflow.sensors.base_sensor_operator import BaseSensorOperator +from airflow.utils.decorators import apply_defaults + + +class RedisPubSubSensor(BaseSensorOperator): + """ + Redis sensor for reading a message from pub sub channels + """ + template_fields = ('channels',) + ui_color = '#f0eee4' + + @apply_defaults + def __init__(self, channels, hook, *args, **kwargs): Review comment: @mans2singh disadvantage is we have to write code to create hook in DAG file. I think not high cohesion If we pass conn_id str, user could just pass conn_id str to active sensors. For unittest I think we could do like other sensors. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
