zhongjiajie commented on a change in pull request #4712: [AIRFLOW-3892] Create Redis pub sub sensor URL: https://github.com/apache/airflow/pull/4712#discussion_r257489898
########## File path: airflow/contrib/sensors/redis_pub_sub_sensor.py ########## @@ -0,0 +1,76 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from airflow.sensors.base_sensor_operator import BaseSensorOperator +from airflow.utils.decorators import apply_defaults +from airflow.contrib.hooks.redis_hook import RedisHook + + +class RedisPubSubSensor(BaseSensorOperator): + + """ + Redis sensor for reading a message from pub sub channels + """ + template_fields = ('channels',) + ui_color = '#f0eee4' + + @apply_defaults + def __init__(self, channels, redis_conn_id, *args, **kwargs): + """ + Create a new RedisPubSubSensor and subscribe to the channels + + :param channels: The channels to be subscribed to (templated) + :type channels: str or list of str + :param redis_conn_id: the redis connection id + :type redis_conn_id: str + """ + + super(RedisPubSubSensor, self).__init__(*args, **kwargs) + self.channels = channels + self.redis_conn_id = redis_conn_id + self.pubsub = RedisHook(redis_conn_id=self.redis_conn_id).get_conn().pubsub() Review comment: Should we move L47 and L48 into function `poke` before `message = self.pubsub.get_message()`? discuss ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
