feng-tao commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-465266733
 
 
   @ffinfo , the fact is that @astahlman has found many issues on this branch. 
And what does it mean by `because the dagrun did already exist` ? Are we still 
going to have issues if there are previous DAGRuns exist? Do we still need to 
run `airflow resetdb`?  And what does it mean by "testing scheduler is not 
needed"?  Now the scheduler(normal or backfill) needs to get the graph edge and 
push it to db? How could it be not related if that's the case?
   
   And I am not comfortable with the UX here( that new giant button `show graph 
from file`). This brings the confusion to the user IMO.   And to be honest, I 
think your issue does exist but only happens in a very rare case. And during my 
1-year involvement of Airflow with production, I have never experienced with 
the issue or heard our users complain about the issues in our 500 DAGs 
production cluster. Hence I am not sure if it justified with such complicated 
change.
   
   I am -1(binding) with this branch if that's the way it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to