feng-tao commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-466689999
 
 
   @ffinfo , thanks for the update. Just to be clear, I am just no very 
satisfied with the last change I saw. If the main concerns are addressed, I am 
more than happy to give +1.
   
   Couples of concerns recap:
   1. the big button shown in the graph view.
   2. Airflow with historical DAGRun requires running `airflow resetdb`
   3. DAG with empty DAGRuns won't enter the graph view.
   4. DAG Graph shape get changed when backfill past DAGRun.
   (@astahlman anything else?)
   
   If the pr has addressed the above concern, I will take another look next 
week although my local env can't build this branch successfully last time, need 
to figure out what's happening on my side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to