feng-tao commented on issue #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#issuecomment-465339617 thanks @Fokko for your thorough response. To clarify, I am not against the idea of this pr. I am just against if this is the final version. Hence I suggest the author post the testings here instead of every time we find something new issues. And given it is an AIF, it should require 3 PMC +1 based on https://www.apache.org/foundation/voting.html ``` VOTES ON CODE MODIFICATION For code-modification votes, +1 votes are in favour of the proposal, but -1 votes are vetos and kill the proposal dead until all vetoers withdraw their -1 votes. Unless a vote has been declared as using lazy consensus , three +1 votes are required for a code-modification proposal to pass. Whole numbers are recommended for this type of vote, as the opinion being expressed is Boolean: 'I approve/do not approve of this change.' A code-modification proposal may be stopped dead in its tracks by a -1 vote by a qualified voter. ``` CC @bolkedebruin @jghoman
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
