OmairK commented on pull request #11179:
URL: https://github.com/apache/airflow/pull/11179#issuecomment-700197993
> BATS failed, can you take a look at it please @OmairK
>
> ```
> Run BATS bash tests for changed bash
files........................................................................................Failed
> ```
Yes, I looked into it the bats-tests pre-commit hook its running bats on .sh
files rather than just .bats scripts.
```
- id: bats-tests
name: Run BATS bash tests for changed bash files
language: system
entry: "./scripts/ci/pre_commit/pre_commit_bat_tests.sh"
files: ^breeze$|^breeze-complete$|\.sh$|\.bash$|.bats
exclude: ^tests/bats/in_container
```
I am thinking of modifying this pre-commit hook to run:
- Only the bats tests that were created/changed in case of only .bats files
being added/updated.
- All bats tests (excluding the in_container) if the change has a mix of
shell scripts and bats tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
