potiuk commented on a change in pull request #11179:
URL: https://github.com/apache/airflow/pull/11179#discussion_r496496216
##########
File path: .pre-commit-config.yaml
##########
@@ -406,8 +412,9 @@ repos:
name: Run BATS bash tests for changed bash files
language: system
entry: "./scripts/ci/pre_commit/pre_commit_bat_tests.sh"
- files: ^breeze$|^breeze-complete$|\.sh$|\.bash$|.bats$
- pass_filenames: false
+ files: ^breeze$|^breeze-complete$|\.sh$|\.bash$|\.bats$
+ exclude: ^tests/bats/in_container/.*bats$
+ pass_filenames: true
Review comment:
See the general comment - I love that we can run the scripts
individually and pass .bat files as parameters, but in pre-commit we should set
pass-filenames to "false" because we always want to run all .bat tests if any
of the relevant files change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
