potiuk commented on pull request #11179: URL: https://github.com/apache/airflow/pull/11179#issuecomment-700521688
@OmairK. I think this is very close :). I already had similar cases in the past. The scripts you have now will handle both cases very well - pre-commit run and manual execution :). But we need one more small change - change pass_filenames to false :). Pre-commit works best if it acts on the files that got changed, but this case is a bit different. I think eventually we want to run all the relevant .bat tests any time any of the relevant .sh or .bat tests change (because we have no direct relation .sh -> .bat). On the other hand - it's great to have the scripts handy to manually run individual bats tests by providing them as parameters. And I think your scripts are great for that. There should be two cases when pre-commits are run: a) If any of the "out-container" .sh files or "out-container" .bat files change -> run all "out-container" bat tests b) If any of the "in-container" .sh files or "in-container" .bat files change -> run all "in-container" bat tests In the pre-commit there is 'pass_filename: false" option - which will simply run pre-commit without passing any of the filenames to script. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
