potiuk opened a new pull request #11276:
URL: https://github.com/apache/airflow/pull/11276


   Replaces the annoying comments with "workflow_run" links
   with Run Checks. Now we will be able to see the "Build Image"
   checks in the "Checks" section including their status and direct
   link to the steps running the image builds as "Details" link.
   
   Unfortunately Github Actions do not handle well the links to
   details - even if you provide details_url to link to the other
   run, the "Build Image" checks appear in the original workflow,
   that's why we had to introduce another link in the summary of
   the Build Image check that links to the actual workflow.
   
   This is the best I can do now: 
   
   The "Build Image" checks appear in the "checks"  of the PR. You can see 
their status (in_progress/ok/failed) and when you click such a "Build Image 
check" you will see the link to the other workflow running the build:
   
   ![Screenshot from 2020-10-05 
11-17-12](https://user-images.githubusercontent.com/595491/95062023-ada92200-06fc-11eb-8f1d-66b353016940.png)
   
   I think it's a very good solution - much better than the annoying comment.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to