ashb commented on pull request #11276: URL: https://github.com/apache/airflow/pull/11276#issuecomment-703531663
> > @potiuk This is better than it was, certainly, but a question: Is it possible to have the build image workflow run against _the actual PR_ as a second workflow, as we do with the "Up to Date" check, WIP, or the CodeQL? I.e. what is special about the Build Image workflow that means it has to be against master, not the PR? > > It runs as 'workflow_run' which is the only way to get "write" permission that allows to push the build image to the registry. There is no other way to do it. Ahhh, PRs on forked repos only have read permissions, got it. Makes sense. > > We should also show such a message on the "Wait for X images" stage: > > We cannot do it easily. Currently, there is no easy way to find out which of the workflows in the "workflow_run" is the one that runs the build. This link is missing in the current API. It might require even more complex querying which is the workflow_run tha we should link to and it requires another custom Github Action likely to loop through all the workflow runs running and finding the right one. I (or maybe someone else who would like to take care about it) might want to do it, but I want to do now minimal set of changes that are possible. Ah yeah, just looked at how this all works. Got it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
