mik-laj commented on a change in pull request #11318:
URL: https://github.com/apache/airflow/pull/11318#discussion_r501350091
##########
File path: airflow/providers/google/cloud/transfers/sql_to_gcs.py
##########
@@ -232,6 +232,10 @@ def _write_local_data_files(self, cursor):
return files_to_upload
+ def get_cursor_iterator(self, cursor):
Review comment:
Why is it necessary?
[pep-0249](https://www.python.org/dev/peps/pep-0249/) recommends that cursor
have a `__iiter__` method, so this should work without it. If the Vertica
library does not implement it, I think it is worth fixing the problem and not
try to change the interface of other classes. the adapter design pattern can be
helpful here. See:
https://github.com/apache/airflow/blob/2bac4810a48d43692be8f585167925e2c48abb46/airflow/providers/google/cloud/transfers/presto_to_gcs.py#L27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
