vshshjn7 commented on a change in pull request #11318:
URL: https://github.com/apache/airflow/pull/11318#discussion_r501609745
##########
File path: airflow/providers/google/cloud/transfers/sql_to_gcs.py
##########
@@ -232,6 +232,10 @@ def _write_local_data_files(self, cursor):
return files_to_upload
+ def get_cursor_iterator(self, cursor):
Review comment:
As per pep-0249, `__iter__` is an optional dbapi extension. So, other
datastores also may or may not choose to implement this.
The above change will not change the existing functionality, rather will
give the flexibility to the user to define/modify the iterator if in case it is
not provided by the datastore cursor.
I am fine with making changes, but I feel this gives more flexibility to the
user to modify or define iterator if he wants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
