mik-laj commented on a change in pull request #11318:
URL: https://github.com/apache/airflow/pull/11318#discussion_r504945638
##########
File path: airflow/providers/google/cloud/transfers/sql_to_gcs.py
##########
@@ -232,6 +232,10 @@ def _write_local_data_files(self, cursor):
return files_to_upload
+ def get_cursor_iterator(self, cursor):
Review comment:
I think that PEP documents should also be treated as a recommendation
and good practice. In this case, PEP recommends creating an interface with
`__iter__` method instead of alternative solutions such as the get_iter methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
