ashb commented on a change in pull request #11541:
URL: https://github.com/apache/airflow/pull/11541#discussion_r505402311
##########
File path: .github/workflows/ci.yml
##########
@@ -105,20 +108,23 @@ jobs:
- name: Set wait for image
id: wait-for-image
run: |
- if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == "true" ]]; then
+ if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == 'true' ]]; then
echo "::set-output name=wait-for-image::true"
else
echo "::set-output name=wait-for-image::false"
fi
- name: Selective tests
id: selective-tests
- run: ./scripts/ci/selective_tests.sh
+ run: ./scripts/ci/selective_tests.sh ${{github.sha}}
helm-tests:
timeout-minutes: 5
name: "Checks: Helm tests"
runs-on: ubuntu-latest
- if: github.repository == 'apache/airflow' || github.event_name !=
'schedule'
+ needs: [build-info]
+ if: >
+ needs.build-info.outputs.needs-helm-tests == 'true' &&
+ (github.repository == 'apache/airflow' || github.event_name !=
'schedule')
Review comment:
(Not a change on this PR, but why do we care what repository we are for
helm chart tests?
##########
File path: .github/workflows/ci.yml
##########
@@ -105,20 +108,23 @@ jobs:
- name: Set wait for image
id: wait-for-image
run: |
- if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == "true" ]]; then
+ if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == 'true' ]]; then
echo "::set-output name=wait-for-image::true"
else
echo "::set-output name=wait-for-image::false"
fi
- name: Selective tests
id: selective-tests
- run: ./scripts/ci/selective_tests.sh
+ run: ./scripts/ci/selective_tests.sh ${{github.sha}}
helm-tests:
timeout-minutes: 5
name: "Checks: Helm tests"
runs-on: ubuntu-latest
- if: github.repository == 'apache/airflow' || github.event_name !=
'schedule'
+ needs: [build-info]
+ if: >
+ needs.build-info.outputs.needs-helm-tests == 'true' &&
+ (github.repository == 'apache/airflow' || github.event_name !=
'schedule')
Review comment:
(Not a change on this PR, but why do we care what repository we are for
helm chart tests?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
