ashb commented on a change in pull request #11541:
URL: https://github.com/apache/airflow/pull/11541#discussion_r505405592
##########
File path: .github/workflows/ci.yml
##########
@@ -175,9 +185,9 @@ jobs:
SKIP: "pylint"
MOUNT_LOCAL_SOURCES: "true"
PYTHON_MAJOR_MINOR_VERSION:
${{needs.build-info.outputs.defaultPythonVersion}}
- if: github.repository == 'apache/airflow' || github.event_name !=
'schedule'
- # We want to make sure we have latest sources as only in_container
scripts are added
- # to the image but we want to static-check all of them
+ if: >
+ needs.build-info.outputs.needs-image-build == 'true' &&
Review comment:
Running (or not running) static checks based on if we need to build an
image or not seems confusing. I know this makes sense right now, but it feels
like a side-effect: for instance a possible optimization we might do in future
once we have more selective tests of providers is to rebuild the image much
less often and mount sources in.
Could we come up with a new name for this output, even if it's always set in
the same place as needs-image-build right now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
