ashb commented on a change in pull request #11541:
URL: https://github.com/apache/airflow/pull/11541#discussion_r505413608
##########
File path: scripts/ci/selective_tests.sh
##########
@@ -125,18 +182,60 @@ function count_changed_files() {
echo "${count_changed_files}"
}
-function run_all_tests_when_push_or_schedule() {
+function run_everything_when_push_or_schedule() {
if [[ ${GITHUB_EVENT_NAME} == "push" || ${GITHUB_EVENT_NAME} == "schedule"
]]; then
echo
echo "Always run all tests in case of push/schedule events"
echo
- set_outputs_run_all_tests
- exit
+ set_outputs_run_everything_and_exit
+ fi
+}
+
+function check_if_api_tests_should_be_run() {
+ local api_triggering_patterns=(
+ "^airflow/api"
+ )
+ pattern_array=("${api_triggering_patterns[@]}")
+ show_changed_files "$(get_regexp_from_patterns)"
Review comment:
All of the `show_changes_files` are being passed an argument that isn't
even used.
```suggestion
show_changed_files
```
No reference to `$@` or `$1` etc in
https://github.com/apache/airflow/blob/3447b55ba57a06c3820d1f754835e7d7f9a1fc68/scripts/ci/selective_tests.sh#L108-L116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
