potiuk commented on a change in pull request #11541:
URL: https://github.com/apache/airflow/pull/11541#discussion_r505450809
##########
File path: scripts/ci/selective_tests.sh
##########
@@ -125,18 +182,60 @@ function count_changed_files() {
echo "${count_changed_files}"
}
-function run_all_tests_when_push_or_schedule() {
+function run_everything_when_push_or_schedule() {
if [[ ${GITHUB_EVENT_NAME} == "push" || ${GITHUB_EVENT_NAME} == "schedule"
]]; then
echo
echo "Always run all tests in case of push/schedule events"
echo
- set_outputs_run_all_tests
- exit
+ set_outputs_run_everything_and_exit
+ fi
+}
+
+function check_if_api_tests_should_be_run() {
+ local api_triggering_patterns=(
+ "^airflow/api"
Review comment:
The intention here is, that if any "core/other" file changes (including
models), then always all the tests are run (so all API, unit etc. tests should
be always run when those change). So there is no need to add them here
specifically. If "models" change, then everything else - including providers,
cli, etc. are impacted and all tests should be run.
I will double-check if that's the case.
This selection is only really used, in case ONLY API files change - then
ONLY API tests should be run. This work for sure for the regular "unit" API
tests, but I will double check if that's the case for the client generation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
