potiuk commented on a change in pull request #11541:
URL: https://github.com/apache/airflow/pull/11541#discussion_r505444855
##########
File path: .github/workflows/ci.yml
##########
@@ -175,9 +185,9 @@ jobs:
SKIP: "pylint"
MOUNT_LOCAL_SOURCES: "true"
PYTHON_MAJOR_MINOR_VERSION:
${{needs.build-info.outputs.defaultPythonVersion}}
- if: github.repository == 'apache/airflow' || github.event_name !=
'schedule'
- # We want to make sure we have latest sources as only in_container
scripts are added
- # to the image but we want to static-check all of them
+ if: >
+ needs.build-info.outputs.needs-image-build == 'true' &&
Review comment:
Actually. it's a good name in this case (I even had it done like that
before). I thought about renaming it, but I think it reflects pretty well both
intention and behaviour.
With this change,, we add two versions of static checks - one that runs with
CI image built ("Static checks" and the other without "Statich checks: no CI
image"). If (in selective test scripts) we decide that image build is needed -
we run the full set of static checks, if we decide that we do not need it, we
run the "no-ci-image one". I think it is really proper logic and not a side
effect at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
