potiuk commented on a change in pull request #11541:
URL: https://github.com/apache/airflow/pull/11541#discussion_r505436699
##########
File path: .github/workflows/ci.yml
##########
@@ -105,20 +108,23 @@ jobs:
- name: Set wait for image
id: wait-for-image
run: |
- if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == "true" ]]; then
+ if [[ ${GITHUB_REGISTRY_WAIT_FOR_IMAGE} == 'true' ]]; then
echo "::set-output name=wait-for-image::true"
else
echo "::set-output name=wait-for-image::false"
fi
- name: Selective tests
id: selective-tests
- run: ./scripts/ci/selective_tests.sh
+ run: ./scripts/ci/selective_tests.sh ${{github.sha}}
Review comment:
The ``github.sha`` IS the merge sha for PRs (and for all other types of
events we do not use it). It's not quite apparent, GH documentation is not
clear about it entirely but you can read about it for example here:
https://frontside.com/blog/2020-05-26-github-actions-pull_request/#how-does-pull_request-affect-actionscheckout
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
