potiuk commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r531552850
##########
File path: airflow/providers/microsoft/mssql/hooks/mssql.py
##########
@@ -36,7 +37,7 @@ def __init__(self, *args, **kwargs) -> None:
(
"This class is deprecated and will be removed in Airflow
2.0.\n"
"pymssql is discontinued. See
https://github.com/pymssql/pymssql/issues/668.\n";
- "Please use `airflow.providers.odbc.hooks.odbc.OdbcHook`"
Review comment:
I did not even know it's been revived. It was not clear from the warning
still there - but I see that you un-deprecated the whole module in
https://github.com/apache/airflow/commit/765d29ecc9fd6a3220efa0a6c4ce10848f5cbf82
- but not the class itself, that's why I added the ODBCHook. In this case, yes
- we should remove the deprecation and this class is not needed any more
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
