potiuk commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r531566988



##########
File path: dev/provider_packages/SETUP_TEMPLATE.py.jinja2
##########
@@ -59,19 +59,6 @@ def do_setup(version_suffix_for_pypi=''):
         packages=find_namespace_packages(
             include=['airflow.providers.{{ PROVIDER_PACKAGE_ID }}',
                      'airflow.providers.{{ PROVIDER_PACKAGE_ID }}.*']),
-        package_data={ '': [
-{% if PROVIDER_PACKAGE_ID == 'amazon' %}
-          "*.json",
-{% elif PROVIDER_PACKAGE_ID == 'cncf.kubernetes' %}
-          "*.yaml",
-{% elif PROVIDER_PACKAGE_ID == 'google' %}
-          "*.yaml",
-          "*.sql",
-{% elif PROVIDER_PACKAGE_ID == 'papermill' %}
-          "*.ipynb",
-{% endif %}
-            ],
-        },

Review comment:
       ```
   [jarek:~/code/airflow] [test-pip-check] 
add-connection-discovery-to-providers+ ± unzip -t 
dist/apache_airflow_providers_google-1.0.0b2-py3-none-any.whl | grep sql 
       testing: 
airflow/providers/google/cloud/example_dags/example_bigquery_query.sql   OK
       testing: 
airflow/providers/google/cloud/example_dags/example_cloud_sql.py   OK
       testing: 
airflow/providers/google/cloud/example_dags/example_cloud_sql_query.py   OK
       testing: 
airflow/providers/google/cloud/example_dags/example_dataflow_sql.py   OK
       testing: 
airflow/providers/google/cloud/example_dags/example_mysql_to_gcs.py   OK
       testing: airflow/providers/google/cloud/example_dags/example_spanner.sql 
  OK
       testing: airflow/providers/google/cloud/hooks/cloud_sql.py   OK
       testing: airflow/providers/google/cloud/operators/cloud_sql.py   OK
       testing: airflow/providers/google/cloud/transfers/bigquery_to_mysql.py   
OK
       testing: airflow/providers/google/cloud/transfers/mssql_to_gcs.py   OK
       testing: airflow/providers/google/cloud/transfers/mysql_to_gcs.py   OK
       testing: airflow/providers/google/cloud/transfers/sql_to_gcs.py   OK
   [jarek:~/code/airflow] [test-pip-check] 
add-connection-discovery-to-providers+ ± tar -tvzf 
dist/apache-airflow-providers-google-1.0.0b2.tar.gz| grep sql          
   -rw-r--r-- root/root     10832 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/example_dags/example_cloud_sql_query.py
   -rw-r--r-- root/root      2471 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/example_dags/example_dataflow_sql.py
   -rw-r--r-- root/root       879 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/example_dags/example_spanner.sql
   -rw-r--r-- root/root      1465 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/example_dags/example_mysql_to_gcs.py
   -rw-r--r-- root/root     13397 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/example_dags/example_cloud_sql.py
   -rw-r--r-- root/root       816 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/example_dags/example_bigquery_query.sql
   -rw-r--r-- root/root     44573 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/operators/cloud_sql.py
   -rw-r--r-- root/root     44392 2020-11-27 12:15 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/hooks/cloud_sql.py
   -rw-r--r-- root/root      6769 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/transfers/bigquery_to_mysql.py
   -rw-r--r-- root/root      5107 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/transfers/mysql_to_gcs.py
   -rw-r--r-- root/root      3093 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/transfers/mssql_to_gcs.py
   -rw-r--r-- root/root     13610 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/transfers/sql_to_gcs.py
   [jarek:~/code/airflow] [test-pip-check] 
add-connection-discovery-to-providers+ ± 
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to