potiuk commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r531566639



##########
File path: dev/provider_packages/SETUP_TEMPLATE.py.jinja2
##########
@@ -59,19 +59,6 @@ def do_setup(version_suffix_for_pypi=''):
         packages=find_namespace_packages(
             include=['airflow.providers.{{ PROVIDER_PACKAGE_ID }}',
                      'airflow.providers.{{ PROVIDER_PACKAGE_ID }}.*']),
-        package_data={ '': [
-{% if PROVIDER_PACKAGE_ID == 'amazon' %}
-          "*.json",
-{% elif PROVIDER_PACKAGE_ID == 'cncf.kubernetes' %}
-          "*.yaml",
-{% elif PROVIDER_PACKAGE_ID == 'google' %}
-          "*.yaml",
-          "*.sql",
-{% elif PROVIDER_PACKAGE_ID == 'papermill' %}
-          "*.ipynb",
-{% endif %}
-            ],
-        },

Review comment:
       Yep - it seems to work with just MANIFEST.in:
   
   ```
   jarek:~/code/airflow] [test-pip-check] 
add-connection-discovery-to-providers+ 1 ± tar -tvzf 
dist/apache-airflow-providers-google-1.0.0b2.tar.gz| grep yaml
   -rw-r--r-- root/root       860 2020-11-26 14:08 
apache-airflow-providers-google-1.0.0b2/airflow/providers/google/cloud/example_dags/example_cloud_build.yaml
   ```
   
   ```
   [jarek:~/code/airflow] [test-pip-check] 
add-connection-discovery-to-providers+ ± unzip -t 
dist/apache_airflow_providers_google-1.0.0b2-py3-none-any.whl | grep yaml
       testing: 
airflow/providers/google/cloud/example_dags/example_cloud_build.yaml   OK
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to