[GitHub] [airflow] mik-laj commented on a change in pull request #12466: Adds support for Connection/Hook discovery from providers

[GitBox]

mik-laj commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r532069124



##########
File path: airflow/provider.yaml.schema.json
##########
@@ -167,6 +170,13 @@
           "python-module"
         ]
       }
+    },
+    "hook-class-names": {
+      "type": "array",
+      "items": {
+        "type": "string",
+        "description": "Hooks class names that provide connection types to 
core"

Review comment:
       It seems to me that we should try to describe the most general fields. 
If we need it, we can also describe lower level elements.
   
   From a validation perspective, these fields are ignored, but describing the 
list of items provides better hints in the IDE.
   Before:
   <img width="609" alt="Screenshot 2020-11-28 at 18 11 53" 
src="https://user-images.githubusercontent.com/12058428/100521656-44e2a100-31a5-11eb-9b84-1cc55bc016e9.png";>
   
   After:
   <img width="639" alt="Screenshot 2020-11-28 at 18 10 02" 
src="https://user-images.githubusercontent.com/12058428/100521645-3a280c00-31a5-11eb-8412-efd798a608e9.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org