potiuk commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r532159860
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -67,7 +67,9 @@
class BigQueryHook(GoogleBaseHook, DbApiHook):
"""Interact with BigQuery. This hook uses the Google Cloud connection."""
- conn_name_attr = 'gcp_conn_id' # type: str
+ conn_name_attr = 'gcp_conn_id'
+ default_conn_name = 'google_cloud_default'
+ conn_type = 'google_cloud_platform'
Review comment:
Possibly. I just do not want to fix all those in this PR. I simply
converted what I found in the original connection.py.
I propose that we start agreeing the approach there and standardize those,
but this shoudl be a completely different PR (and if you want to propose some
guidelines and standard/consistent approach for that - feel free).
I do not want to scope-creep that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
