potiuk commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r532081844
##########
File path: airflow/provider.yaml.schema.json
##########
@@ -167,6 +170,13 @@
"python-module"
]
}
+ },
+ "hook-class-names": {
Review comment:
What's your proposal @mik-laj ? How should we refactor it ? Also
remember that it builds on previously existing fields in DBApi (I followed the
same convention).
We could use Protocol (but it's Python 3.8
https://www.python.org/dev/peps/pep-0544/) - we already backport it from
typing_extensions and seems like exactly what we could use. We could have Hook
also derive from DiscoverableHook (for example - I have no good name for it)
and have all the hooks listed there implement it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]