mik-laj commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r532160271
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -67,7 +67,9 @@
class BigQueryHook(GoogleBaseHook, DbApiHook):
"""Interact with BigQuery. This hook uses the Google Cloud connection."""
- conn_name_attr = 'gcp_conn_id' # type: str
+ conn_name_attr = 'gcp_conn_id'
+ default_conn_name = 'google_cloud_default'
+ conn_type = 'google_cloud_platform'
Review comment:
We don't need a separate type for BigQuery. In Airflow 1.10, we had a
few more connection types, but in Airflow 2.0, this was standardized and most
connections use one connection type. In some exceptional situations we need
additional configuration options and then we use a new type of connection.
See:
http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow-providers-google/latest/connections/index.html
https://github.com/apache/airflow/blob/master/UPDATING.md#normalize-gcp_conn_id-for-google-cloud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
