mik-laj commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r532191669
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -67,7 +67,9 @@
class BigQueryHook(GoogleBaseHook, DbApiHook):
"""Interact with BigQuery. This hook uses the Google Cloud connection."""
- conn_name_attr = 'gcp_conn_id' # type: str
+ conn_name_attr = 'gcp_conn_id'
+ default_conn_name = 'google_cloud_default'
+ conn_type = 'google_cloud_platform'
Review comment:
@ashb Since BigQuery implements DBApiHook, we should probably create a
new connection type to be used by DbApiHook.
I am afraid of registering all hooks because that will also mean that they
will be loaded. And loading all modules from all Google libraries into memory
is an expensive operation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
