ashb commented on a change in pull request #12742:
URL: https://github.com/apache/airflow/pull/12742#discussion_r533672608
##########
File path: tests/core/test_configuration.py
##########
@@ -557,6 +557,23 @@ def test_command_from_env(self):
# the environment variable's echo command
self.assertEqual(test_cmdenv_conf.get('testcmdenv',
'notacommand'), 'OK')
+ def test_sensitive_config_values(self):
Review comment:
I'm with @mik-laj on this -- the test is _tightly_ coupled to the exact
implementation detail, meaning even the slightest change (other than
formatting) to the code means the test needs to be updated.
You've essentially just re-written the same code twice here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
