mik-laj commented on a change in pull request #12742:
URL: https://github.com/apache/airflow/pull/12742#discussion_r533675147



##########
File path: tests/core/test_configuration.py
##########
@@ -557,6 +557,23 @@ def test_command_from_env(self):
             # the environment variable's echo command
             self.assertEqual(test_cmdenv_conf.get('testcmdenv', 
'notacommand'), 'OK')
 
+    def test_sensitive_config_values(self):

Review comment:
       > template_field contains the list we expect it to should be enough
   
   It is not common.
   
   > Otherwise we will have tons of tests for each_template_field * Number of 
Operators
   
   In my opinion, it is enough to verify that this behavior only works for one 
key. We don't need to check that this will work for all keys if the key list is 
a static list. If something works for one value, it will also work for all 
other values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to