mik-laj commented on a change in pull request #12742:
URL: https://github.com/apache/airflow/pull/12742#discussion_r533697937



##########
File path: tests/core/test_configuration.py
##########
@@ -557,6 +557,23 @@ def test_command_from_env(self):
             # the environment variable's echo command
             self.assertEqual(test_cmdenv_conf.get('testcmdenv', 
'notacommand'), 'OK')
 
+    def test_sensitive_config_values(self):

Review comment:
       > Here is the issue: https://issues.apache.org/jira/browse/AIRFLOW-5136 
that broke 1.10.4 . We started verifying the list of template fields after that.
   
   Comparing the contents of the `template_fields` field would not help us in 
detecting this problem. You need to check that `template_fields` field contains 
the fields that are set in the constructor. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to