potiuk commented on a change in pull request #4938: [AIRFLOW-4117]
Multi-staging Image - Travis CI tests [Step 3/3]
URL: https://github.com/apache/airflow/pull/4938#discussion_r268688309
##########
File path: scripts/ci/docker-compose-interactive.yml
##########
@@ -14,6 +13,8 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-#
-docker-compose -f scripts/ci/docker-compose.yml run --rm airflow-testing
"${@-bash}"
+version: "2.2"
+services:
+ airflow-testing:
+ entrypoint: [ "/bin/bash", "-c" ]
Review comment:
Very good point. It's an artifact from earlier tries with tini/dumb-init.
When I played with it I had dumb-init set in the main file, and it messed with
closing stdin/stdout for interactive runs. But I decided it's not really needed
for running tests via docker compose, so I remove this file now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
