potiuk commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r268693677
########## File path: scripts/ci/in_container/run_ci.sh ########## @@ -0,0 +1,127 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -euo pipefail + +MY_DIR=$(cd "$(dirname "$0")"; pwd) + +if [[ ${AIRFLOW_CI_VERBOSE:="false"} == "true" ]]; then + set -x +fi + +AIRFLOW_ROOT="${MY_DIR}/../.." + +PYTHON_VERSION=${PYTHON_VERSION:=3.6} +ENV=${ENV:=docker} +BACKEND=${BACKEND:=sqlite} +KUBERNETES_VERSION=${KUBERNETES_VERSION:=} + +RUN_TESTS=${RUN_TESTS:="true"} + +ARGS=$@ + +if [[ -z "${AIRFLOW_HOME:=}" ]]; then + echo + echo AIRFLOW_HOME not set !!!! + echo + exit 1 +fi + +# Fix file permissions +if [[ -d $HOME/.minikube ]]; then + sudo chown -R airflow.airflow $HOME/.kube $HOME/.minikube +fi + +if [[ ${PYTHON_VERSION} == 3* ]]; then + PIP=pip3 +else + PIP=pip2 +fi + +if [[ "${ENV}" == "docker" ]]; then Review comment: When we run "kubernetes" tests. They use different ENV setting - I took it straight from the current setup in tox.ini : https://github.com/apache/airflow/blob/master/tox.ini#L20 I actually discussed it with Gerardo in https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-7+Simplified+development+workflow?focusedCommentId=103102620#comment-103102620 that we want to minimise changes (well - they are huge anyway) and improve kubernetes tests as next step. That would involve installing kubernetes via docker-compose image likely or running the tests in GKE (maybe). But I would like to avoid changing the "logic" of tests in this change - I'd rather focus on changing the "engine" and improve logic later on. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
