dstandish commented on a change in pull request #13423:
URL: https://github.com/apache/airflow/pull/13423#discussion_r552053858
##########
File path: airflow/operators/bash.py
##########
@@ -145,43 +141,15 @@ def execute(self, context):
'\n'.join([f"{k}={v}" for k, v in airflow_context_vars.items()]),
)
env.update(airflow_context_vars)
+ return env
+
+ def execute(self, context=None):
Review comment:
i like making context optional where it's not used (or in some cases
even when it is used, make it optional to use it)
shouldn't be in this PR i think i left it in subconsiously to start
discussion.
will remove
and i have created a discussion in the proper place:
https://github.com/apache/airflow/discussions/13492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
