dstandish commented on a change in pull request #13423: URL: https://github.com/apache/airflow/pull/13423#discussion_r552057380
########## File path: airflow/hooks/bash.py ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import os +import signal +from subprocess import PIPE, STDOUT, Popen +from tempfile import TemporaryDirectory, gettempdir +from typing import Dict, Optional + +from airflow import AirflowException +from airflow.hooks.base import BaseHook + + +class BashHook(BaseHook): Review comment: operators == orchestrator of task hooks == vocabulary of operators i had this thought too as i typed out a hook with no init params. but i don't think that connections are really what defines a hook. it's the collection of methods used for interacting with a resource. there could be many hooks that don't need to worry about auth. operators do one thing. hooks can potentially do very many things. so the things that have general use should get pushed down to a hook that can be reused. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
