ayushchauhan0811 commented on pull request #13832: URL: https://github.com/apache/airflow/pull/13832#issuecomment-766296537
> a) add some comments describing what's going on - mention that the method might throw the timeout exception and that it should be passed back to execute method (this way the next person coming here will not have to dig deeper and will not add the try/catch back. I have added comments to explain why the try-catch block has been removed. > b) can you please add a unit test case with this case to prevent regressions? @potiuk I tried looking at other operators to see how they have implemented the timeout unit-test but didn't anything. Can you guide me on how to proceed with writing test for this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
