potiuk commented on pull request #13832:
URL: https://github.com/apache/airflow/pull/13832#issuecomment-766306701


   > I have fixed the failing test and added a try-catch block in submit_job() 
back. Since airflow task will only get timeout during monitor_job function 
execution.
   > 
   > Reason: The response of 
[batch.submit_job](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/batch.html#Batch.Client.submit_job)
 doesn't include a separate failure section to list the failures associated 
with the call. So either we can change the exception here 
[test_batch.py#L135](https://github.com/apache/airflow/blob/master/tests/providers/amazon/aws/operators/test_batch.py#L135)
 to generic `Exception` or add a try-catch block in submit_job()
   
   Or maybe we should have "test_execute_with_failure" and 
"test_execute_with_timeout" as two separate methods ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to