ayushchauhan0811 commented on pull request #13832: URL: https://github.com/apache/airflow/pull/13832#issuecomment-766307310
> Or maybe we should have "test_execute_with_failure" and "test_execute_with_timeout" as two separate methods? In the current implementation of test_execute_with_failures, we pass the return value of submit_job of the mock client to be an empty dict which throws TypeError in [batch.py#L177](https://github.com/apache/airflow/blob/master/airflow/providers/amazon/aws/operators/batch.py#L177). If we don't use a try-catch block in submit_job() and reraise all expections as `AirflowException`, our unit-test will not be covering all the cases ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
