ashb commented on a change in pull request #14019:
URL: https://github.com/apache/airflow/pull/14019#discussion_r568602009
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -375,13 +375,13 @@ <h4 class="modal-title" id="dagModalLabel">
{{ super() }}
<script>
function updateQueryStringParameter(uri, key, value) {
- var re = new RegExp('([?&])' + key + '=.*?(&|$)', 'i');
+ var re = new RegExp(`([?&])${key}=.*?(&|$)`, 'i');
Review comment:
What browsers support this? It's a "relatively" new syntax (and
JS-in-html is not subject to any compile steps)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
