ryanahamilton commented on a change in pull request #14019:
URL: https://github.com/apache/airflow/pull/14019#discussion_r569548659
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -375,13 +375,13 @@ <h4 class="modal-title" id="dagModalLabel">
{{ super() }}
<script>
function updateQueryStringParameter(uri, key, value) {
- var re = new RegExp('([?&])' + key + '=.*?(&|$)', 'i');
+ var re = new RegExp(`([?&])${key}=.*?(&|$)`, 'i');
Review comment:
I conferred w/ @ashb and we're both good on moving forward with this
given it is already in practice. I'll add an issue for migrating all of the
inline scripting to external files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
