XD-DENG commented on a change in pull request #14019:
URL: https://github.com/apache/airflow/pull/14019#discussion_r568606336
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -375,13 +375,13 @@ <h4 class="modal-title" id="dagModalLabel">
{{ super() }}
<script>
function updateQueryStringParameter(uri, key, value) {
- var re = new RegExp('([?&])' + key + '=.*?(&|$)', 'i');
+ var re = new RegExp(`([?&])${key}=.*?(&|$)`, 'i');
Review comment:
Do you mean the template literals? Here is the information:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#browser_compatibility
Only IE is marked "No support"
This should not be a concern to me though, because there is already usage of
template literals in 2.0.0
([example](https://github.com/apache/airflow/blob/2.0.0/airflow/www/templates/airflow/dags.html#L319)
And I believe in some 1.10.* versions too) and so far there is not any
complaint regarding this.
Let me know if you are referring to anything else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
