xinbinhuang commented on a change in pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#discussion_r553733814
##########
File path: airflow/providers/qubole/operators/qubole.py
##########
@@ -267,7 +267,7 @@ def get_hook(self) -> QuboleHook:
return QuboleHook(**self.kwargs)
def __getattribute__(self, name: str) -> str:
- if name in QuboleOperator.template_fields:
+ if name in _get_template_fields(self):
Review comment:
It avoids hardcoding the class name `QuboleOperator` here, so you can
inherit it safely. i.e. so I can remove the `<class-name>.template_fields` in
`qubole_check.py`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
