xinbinhuang commented on a change in pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#discussion_r579695540
##########
File path: tests/core/test_core_to_contrib.py
##########
@@ -84,7 +84,7 @@ def test_is_class_deprecated(self, new_module, old_module):
# is used (=3 or =4 if @apply_defaults)
assert len(warnings) >= 1
assert any(warning.filename == __file__ for warning in
warnings)
- init_mock.assert_called_once_with()
+ init_mock.assert_called_once()
Review comment:
Not sure if there is a better way to do this while maintain back
compatibility. `DruidCheckOperator` has a default `druid_broker_conn_id` that
needs to pass down to `SQLCheckOperator.__init__(conn_id=druid_broker_conn_id,
**kwargs)`.
So if we do `assert_called_once_with()` the test will fail because
`DruidCheckOperator.__ini__()` ==
`SQLCheckOperator.__init__(conn_id=druid_broker_conn_id)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
