[GitHub] [airflow] xinbinhuang commented on a change in pull request #12677: Refactor SQL/BigQuery/Qubole/Druid Check operators

Wed, 24 Feb 2021 10:23:54 -0800 


xinbinhuang commented on a change in pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#discussion_r582196710



##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -69,8 +69,8 @@ class BigQueryHook(GoogleBaseHook, DbApiHook):
 
     conn_name_attr = 'gcp_conn_id'
     default_conn_name = 'google_cloud_default'
-    conn_type = 'google_cloud_platform'
-    hook_name = 'Google Cloud'
+    conn_type = 'bigquery'
+    hook_name = 'BigQuery'

Review comment:
       As similar to other Google cloud connection type:
   
   
![image](https://user-images.githubusercontent.com/27927454/109046868-12ecb800-768a-11eb-970c-6d52905825fa.png)
   
![image](https://user-images.githubusercontent.com/27927454/109046902-1bdd8980-768a-11eb-9cc2-155f26ef7898.png)
   
   Maybe I should rename it to `gcpbigquery` & `Google Bigquery` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to