ashb commented on a change in pull request #14120:
URL: https://github.com/apache/airflow/pull/14120#discussion_r577582898



##########
File path: .github/workflows/build-images-workflow-run.yml
##########
@@ -196,6 +194,7 @@ jobs:
     needs: [cancel-workflow-runs]
     env:
       GITHUB_CONTEXT: ${{ toJson(github) }}
+      GITHUB_REGISTRY_SECRET: ${{ secrets.GITHUB_REGISTRY }}

Review comment:
       Just tested this -- github don't let you create a secret that starts 
with `GITHUB_`
   
   ```suggestion
         GITHUB_REGISTRY_SECRET: ${{ secrets.OVERRIDE_GITHUB_REGISTRY }}
   ```
   
   Or similar.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to