ephraimbuddy commented on a change in pull request #14664:
URL: https://github.com/apache/airflow/pull/14664#discussion_r594521542
##########
File path: airflow/security/permissions.py
##########
@@ -46,8 +46,12 @@
RESOURCE_USER_LDAP_MODELVIEW = "UserLDAPModelView"
RESOURCE_USER_OAUTH_MODELVIEW = "UserOAuthModelView"
RESOURCE_USER_REMOTEUSER_MODELVIEW = "UserRemoteUserModelView"
+RESOURCE_ROLE_MODEL_VIEW = "RoleModelView"
+RESOURCE_PERMISSION_MODEL_VIEW = "PermissionModelView"
# Action Constants
+ACTION_CAN_LIST = "can_list"
+ACTION_CAN_SHOW = "can_show"
Review comment:
Actually there's no `can_read` for the RoleModelView. It's something
that came with FAB. Here's the list of permissions they have for
RoleModelView:
`can show on RoleModelView, can list on RoleModelView, can download on
RoleModelView, can add on RoleModelView, can delete on RoleModelView, can edit
on RoleModelView, copyrole on RoleModelView`.
I got these by looking at the permissions assigned to Admin role in airflow
UI. Security>List Roles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
