kaxil commented on a change in pull request #14664:
URL: https://github.com/apache/airflow/pull/14664#discussion_r594651450



##########
File path: airflow/security/permissions.py
##########
@@ -46,8 +46,12 @@
 RESOURCE_USER_LDAP_MODELVIEW = "UserLDAPModelView"
 RESOURCE_USER_OAUTH_MODELVIEW = "UserOAuthModelView"
 RESOURCE_USER_REMOTEUSER_MODELVIEW = "UserRemoteUserModelView"
+RESOURCE_ROLE_MODEL_VIEW = "RoleModelView"
+RESOURCE_PERMISSION_MODEL_VIEW = "PermissionModelView"
 
 # Action Constants
+ACTION_CAN_LIST = "can_list"
+ACTION_CAN_SHOW = "can_show"

Review comment:
       aah .. so @jhtimmins mapped View based permission to resource based. 
James can you take a look a this and see if we should do the same for it ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to